atris commented on a change in pull request #193: URL: https://github.com/apache/solr/pull/193#discussion_r663657042
########## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java ########## @@ -49,18 +51,6 @@ public CircuitBreakerManager(final boolean enableCircuitBreakerManager) { this.enableCircuitBreakerManager = enableCircuitBreakerManager; } - @Override Review comment: I was considering keeping this change only for Solr 9? The main challenge is that it is cumbersome to maintain two different formats of definition within the same (solrconfig.xml) file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org