janhoy commented on a change in pull request #193:
URL: https://github.com/apache/solr/pull/193#discussion_r664151041



##########
File path: 
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##########
@@ -49,18 +51,6 @@ public CircuitBreakerManager(final boolean 
enableCircuitBreakerManager) {
     this.enableCircuitBreakerManager = enableCircuitBreakerManager;
   }
 
-  @Override

Review comment:
       Ok, if this targets 9.0, then document it and we should be good. Will 
you then deprecate CircuitBreakerManager as a plugin in 8.10 and remove it in 
9.0 in order to not confuse the two?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to