[ 
https://issues.apache.org/jira/browse/SOLR-15512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378482#comment-17378482
 ] 

Ishan Chattopadhyaya commented on SOLR-15512:
---------------------------------------------

Had a cursory glance at your patch and looks good. +1 to extending the 
collector manager.

 

As for this,
{code:java}
        private boolean allowMt(Query query) {
          if (query instanceof RankQuery || query instanceof GraphQuery || 
query instanceof JoinQuery) {
            return false;
          }
          return true;
        } {code}
I think we should use a query visitor to traverse the query to make sure none 
of sub-queries contain these specially excluded queries as well.

> Add support for passing IndexSearcher an executor for multi-threaded 
> multi-segment and possible future multi-threaded per segment search.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-15512
>                 URL: https://issues.apache.org/jira/browse/SOLR-15512
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Robert Miller
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to