markrmiller commented on a change in pull request #214:
URL: https://github.com/apache/solr/pull/214#discussion_r672486250
##########
File path:
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
##########
@@ -313,22 +313,23 @@ private void init(int port) {
if (config.onlyHttp1) {
connector = new ServerConnector(server, new
HttpConnectionFactory(configuration));
} else {
- connector = new ServerConnector(server, new
HttpConnectionFactory(configuration),
- new HTTP2CServerConnectionFactory(configuration));
+ connector = new ServerConnector(server, new
HttpConnectionFactory(configuration), new
HTTP2CServerConnectionFactory(configuration));
}
}
connector.setReuseAddress(true);
connector.setPort(port);
connector.setHost("127.0.0.1");
connector.setIdleTimeout(THREAD_POOL_MAX_IDLE_TIME_MS);
- connector.setStopTimeout(0);
+
server.setConnectors(new Connector[] {connector});
server.setSessionIdManager(new DefaultSessionIdManager(server, new
Random()));
} else {
HttpConfiguration configuration = new HttpConfiguration();
- ServerConnector connector = new ServerConnector(server, new
HttpConnectionFactory(configuration));
+ ServerConnector connector = new ServerConnector(server, new
HttpConnectionFactory(configuration), new
HTTP2CServerConnectionFactory(configuration));
Review comment:
Because it currently does not work with http2, though I have spun these
fixes into: SOLR-15547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
