markrmiller commented on pull request #214: URL: https://github.com/apache/solr/pull/214#issuecomment-882730941
bq. Otherwise, it seems a new module would be more appropriate. You don't back up that statement with any support, other than: bq. test-framework is about publishing utilities for other modules Which I'm not sure I agree with. Initially, I will say its here for: - initial ease - overlap in code/use/idea - often a benchmark will share much with how it's unit test is created, use some of the same supporting classes. The unit tests help test correctness, the jmh benchmarks help test performance. The test-framwork modules has support / base classes for 'testing' (correctness, performance, etc). I like to stack up reasons for going one way or another, but I see the test-framework module as the home of the testing framework, not "about publishing utilities for other modules", so not really adding to my calculus in that form. I also thought there would be more that was shared initially though. And I've sense realized this could use more separation from the randomized testing framework layers and requirements, and the different needs do make reuse of items between benchmark and junit tests a bit less simple and with more of a need to make sure mini clusters and jettyrunners are happy outside of randomized runner stuff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
