madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r676967652
##########
File path: solr/core/src/java/org/apache/solr/query/SolrRangeQuery.java
##########
@@ -452,6 +455,7 @@ private SegState getSegState(LeafReaderContext context)
throws IOException {
if (doCheck) {
answer = createDocSet(solrSearcher, count);
+ // This can be a naked put because the cache usually gets checked in
SolrIndexSearcher
Review comment:
A naked put in this context is a put without a previous call to get or
without a computeIfAbsent. We typically don't want to just insert things into
the cache, but in this case it's _probably_ ok because we would have already
checked in SIS if the entry exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
