madrob commented on pull request #230: URL: https://github.com/apache/solr/pull/230#issuecomment-888736098
I was reading https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/LocalAsyncCache.java#L88-L96 to check this, but somehow convinced myself that because we return the future then we're not blocking on the CHM compute call. But with your comment I realize that in the same thread case we would always be getting a _completed_ future. Need to think some more about whether the common fork-join pool is appropriate here or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
