HoustonPutman commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-897125370
> One thing that stood out to me while documenting all the params was our use of the blob.* prefix (e.g., blob.s3.bucket.name). It made more sense when we had our blob abstraction, but now just seems superfluous. Any objections to removing it? Easy change to make today, much more difficult once we've shipped :D Yeah I agree. We should remove blob entirely (variables, methods, config, etc), shouldn't be mentioned at all in the s3-repository contrib module. And will take a look at the docs! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
