HoustonPutman commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-894415992
Also found a small issue where in S3 you can have a file (not directory), and the API is checking to see if a directory path exists, without the `/` ending on the path. This will return true if there is a file with the name matching the requested directory, even if the requested directory doesn't exist. To fix this I've added a `createDirectoryUri(String location)` method that is a default method on the `AbstractBackupRepository` class, so that it doesn't break compatibility with 3rd party packages. When making this I actually realized that createURI is almost always used for directory locations. But there's no harm in keeping the original method anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
