HoustonPutman commented on a change in pull request #120: URL: https://github.com/apache/solr/pull/120#discussion_r688121677
########## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3IndexInput.java ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.s3; + +import java.io.EOFException; +import java.io.IOException; +import java.io.InputStream; +import java.nio.ByteBuffer; +import java.util.Locale; +import org.apache.lucene.store.BufferedIndexInput; + +class S3IndexInput extends BufferedIndexInput { + + static final int LOCAL_BUFFER_SIZE = 16 * 1024; + + private final InputStream inputStream; + private final long length; + + private long position; + + S3IndexInput(InputStream inputStream, String path, long length) { + super(path); + + this.inputStream = inputStream; + this.length = length; + } + + @Override + protected void readInternal(ByteBuffer b) throws IOException { + + int expectedLength = b.remaining(); + + byte[] localBuffer; + if (b.hasArray()) { + localBuffer = b.array(); + } else { + localBuffer = new byte[LOCAL_BUFFER_SIZE]; + } + + // We have no guarantee we read all the requested bytes from the underlying InputStream + // in a single call. Loop until we reached the requested number of bytes. + while (b.hasRemaining()) { + int read; + + if (b.hasArray()) { + read = inputStream.read(localBuffer, b.position(), b.remaining()); Review comment: You are correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
