HoustonPutman commented on a change in pull request #120:
URL: https://github.com/apache/solr/pull/120#discussion_r689606257
##########
File path:
solr/contrib/blob-repository/src/test/org/apache/solr/blob/backup/BlobBackupRepositoryTest.java
##########
@@ -0,0 +1,366 @@
+/*
Review comment:
Good idea on adding the S3IncrementalBackupTest, will do that before
merging!
I see that GCSIncrementalBackupTest has a set of locales that it works for,
do you think that this is necessary for the S3 test as well, or should I be ok
skipping it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]