[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399245#comment-17399245
]
Dawid Weiss commented on SOLR-15428:
------------------------------------
> The plugin stuff was more about the Gradle build. Don't mix styles to express
> things. Our current build system has a centralized view on modules and
> inherits settings. Benchmark is just another module so it gets all checks
> like forbiddenapis or ECJ or code formatters. But the configuration of those
> should be in the plugin's config file not splattered around all files.
I am quite opinionated about how the gradle build can be organized and some of
the "standard" plugin-based solutions just never worked the way I wanted them
to. The same applies to scattering build logic across build.gradle files - this
leads to duplication and inconsistencies over time. You can prevent a
subproject from automatically getting some of the "aspects" present in the
current build - just explicitly skip it in that particular file which is
responsible for applying the particular piece of build functionality. Yes, it
is the opposite of per-module plugin application - designer's choice.
Remember Lucene/Solr gradle build started in big pains and nothing was easy at
the beginning. Now that it actually works and the ant side is gone there is
nothing preventing you or anybody else from changing the convention I
implemented and discussed above. If you like the plugin system more, go ahead
and move parts of the gradle/ folder structure to a buildSrc plugin, then apply
it in all modules that need it.
> Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and
> performance comparisons and investigation.
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-15428
> URL: https://issues.apache.org/jira/browse/SOLR-15428
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Robert Miller
> Assignee: Mark Robert Miller
> Priority: Major
> Fix For: main (9.0)
>
> Attachments: bench.patch
>
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> I’ve spent a fair amount of time over the years on work around integrating
> Lucene’s benchmark framework into Solr and while I’ve used this with
> additional local work off and on, JMH has become somewhat of a standard for
> micro benchmarks on the JVM. I have some work that provides an initial
> integration, allowing for more targeted micro benchmarks as well as more
> integration type benchmarking using JettySolrRunner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
