[ https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399326#comment-17399326 ]
Dawid Weiss commented on SOLR-15428: ------------------------------------ bq. I am not a fan of the central ./gradle/something.gradle that contains a "if (module == XYZ)". But Dawid already explained this (see above), I cannot add more information to his explanation! Like I said, nothing stands in the way to move those some (or all) of those files under buildSrc and make them proper plugins, then apply them to each module that needs it. It should be fairly automatic refactoring. I like those separate files more also because they allow faster prototyping. I am not going to object if somebody wishes to make plugins out of these files though (I even filed an issue for this [1]. There are pros and cons of each approach. [1] https://issues.apache.org/jira/browse/LUCENE-9875 > Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and > performance comparisons and investigation. > ----------------------------------------------------------------------------------------------------------------------- > > Key: SOLR-15428 > URL: https://issues.apache.org/jira/browse/SOLR-15428 > Project: Solr > Issue Type: New Feature > Reporter: Mark Robert Miller > Assignee: Mark Robert Miller > Priority: Major > Fix For: main (9.0) > > Attachments: bench.patch > > Time Spent: 9h 20m > Remaining Estimate: 0h > > I’ve spent a fair amount of time over the years on work around integrating > Lucene’s benchmark framework into Solr and while I’ve used this with > additional local work off and on, JMH has become somewhat of a standard for > micro benchmarks on the JVM. I have some work that provides an initial > integration, allowing for more targeted micro benchmarks as well as more > integration type benchmarking using JettySolrRunner. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org