diegoceccarelli commented on a change in pull request #242:
URL: https://github.com/apache/solr/pull/242#discussion_r689056500
##########
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java
##########
@@ -292,10 +291,10 @@ private static float scoreNode(float[] featureVector,
RegressionTreeNode regress
return 0f;
}
- if (featureVector[regressionTreeNode.featureIndex] <=
regressionTreeNode.threshold) {
- regressionTreeNode = regressionTreeNode.left;
- } else {
+ if (featureVector[regressionTreeNode.featureIndex] >=
regressionTreeNode.threshold) {
Review comment:
I think `==` should be always on the left. But I agree with
`splitToRight` for backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
