spyk commented on a change in pull request #242: URL: https://github.com/apache/solr/pull/242#discussion_r698497679
########## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java ########## @@ -292,10 +291,10 @@ private static float scoreNode(float[] featureVector, RegressionTreeNode regress return 0f; } - if (featureVector[regressionTreeNode.featureIndex] <= regressionTreeNode.threshold) { - regressionTreeNode = regressionTreeNode.left; - } else { + if (featureVector[regressionTreeNode.featureIndex] >= regressionTreeNode.threshold) { Review comment: @diegoceccarelli not sure if there are different tree models that either split to left or right when equal. At least in the case of the XGBoost model, it seems to split to the right by default. I'll check if I can add that flag functionality on the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org