gus-asf commented on a change in pull request #265:
URL: https://github.com/apache/solr/pull/265#discussion_r696741759
##########
File path:
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
##########
@@ -527,7 +536,7 @@ public void start(boolean reusePort) throws Exception {
}
synchronized (JettySolrRunner.this) {
int cnt = 0;
- while (!waitOnSolr || !dispatchFilter.isRunning() ||
getCoreContainer() == null) {
+ while (!waitOnSolr || !dispatchFilter.isRunning() ) {
Review comment:
Actually I suspect that this entire synchronized block is unnecessary.
The current form of getCoreContainer() now causes a wait and I was getting lock
ups here that the tests didn't ever initialize. I suspect that this startup for
JettySolrRunner is actually single threaded and these two checks always pass,
and actually waiting on something destined to fail anyway, but I haven't gone
back to verify that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
