gus-asf commented on a change in pull request #265:
URL: https://github.com/apache/solr/pull/265#discussion_r696768554
##########
File path:
solr/test-framework/src/java/org/apache/solr/util/BaseTestHarness.java
##########
@@ -77,14 +77,21 @@ public static String validateXPath(String xml, String...
tests)
if (tests==null || tests.length == 0) return null;
- Document document = null;
+ Document document;
try {
+// if (xml.startsWith("<html>")) {
Review comment:
I had these in there, because it makes it clear when you are failing due
to a 404, (much clearer than "unexpected content type" or whatever... )
commented them because I'm not sure this change has no side-effects or wouldn't
bite someone (seems safe but I didn't look into it deeply) wanted the tests to
pass unmodified in any case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
