alextu opened a new pull request #277: URL: https://github.com/apache/solr/pull/277
https://issues.apache.org/jira/browse/SOLR-15603 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Activate gradle local build cache to take advantage of re-using past build executions on a single machine, it improves build time when switching between branches for example. # Solution Set the gradle build cache flag, upgrade gradle to 6.9.1, upgrade a 3rd party plugin and make some tasks cacheable when easily doable. More context below: - the most costly task is `solr:core:test`, it takes advantage of up-to-date checks and local cache if the `tests.seed`property is set to a fixed value. That said it does not take advantage of remote cache because some system properties use absolute path. Using a remote cache would be interesting since you have a CI that could publish to a remote cache node, remote developpers would then have faster local builds. - `checkBrokenLinks, renderJavadoc, renderSiteJavadoc, buildLocalJavadocLinksSite, buildSite, prepareLocalJavadocLinksSiteSources, prepareSiteSources` tasks are now cacheable, but still `:solr:solr-ref-guide:jrubyPrepare` is always executed and quite heavy (dowloading/installing gems). # Tests Manually checked the build performance improvement: ``` ./gradlew clean check -Ptests.seed=DEADBEE BUILD SUCCESSFUL in 27m 26s 409 actionable tasks: 351 executed, 13 from cache, 45 up-to-date ``` ``` ./gradlew clean check -Ptests.seed=DEADBEE BUILD SUCCESSFUL in 45s 409 actionable tasks: 260 executed, 99 from cache, 50 up-to-date ``` # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
