alextu commented on a change in pull request #277:
URL: https://github.com/apache/solr/pull/277#discussion_r698578438
##########
File path: build.gradle
##########
@@ -20,7 +20,7 @@ import java.time.format.DateTimeFormatter
plugins {
id "base"
- id "com.palantir.consistent-versions" version "1.14.0"
Review comment:
Ho, I missed this effort upgrading to 7.x, good stuff ! I can wait for
your branch to be merged and I'll fix my branch
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -184,6 +184,7 @@ ext {
group "Documentation"
description "Builds the ${details.desc}"
+ outputs.cacheIf { true }
Review comment:
it makes the task cacheable, same as putting `@Cacheable` annotation on
a task class (not possible here since it's created on the fly)
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -215,20 +216,21 @@ check.dependsOn checkLocalJavadocLinksSite, checkSite
// Hook site building to assemble.
assemble.dependsOn buildSite
+@CacheableTask
abstract class PrepareSources extends DefaultTask {
// Original Source files we'll be syncing <b>FROM</b>
@InputDirectory
- public DirectoryProperty srcDir = project.objects.directoryProperty()
+ abstract DirectoryProperty getSrcDir()
Review comment:
Yes exactly, so the docs are
[here](https://docs.gradle.org/current/userguide/lazy_configuration.html#working_with_files_in_lazy_properties)
but afaik it does not explain the runtime magical injection happening.
##########
File path: gradle/generate-defaults.gradle
##########
@@ -42,6 +42,7 @@ configure(rootProject) {
"systemProp.file.encoding=UTF-8",
"org.gradle.jvmargs=-Xmx3g", // TODO figure out why "gradlew
check" runs out of memory if 2g
"org.gradle.parallel=true",
+ "org.gradle.caching=true",
Review comment:
Right, so if you're afraid of this, I can remove this setting and you
can enable it through the command line when building, check after a few weeks
of dev if it's acceptable. It's hard to predict the size, currently I see on my
machine it's about 400Mb (after removing the cache directory and running a few
solr builds)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
