[
https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408686#comment-17408686
]
Andrzej Bialecki commented on SOLR-15616:
-----------------------------------------
This makes sense, and the patch looks good - however, I'm not sure about the
configuration mechanism...
I know that the story about Solr configuration is messy and contentious, and we
have several competing mechanisms for configuring various subsystems. For
better or worse, for metrics the main config source is in
{{solr.xml:/solr/metrics}}. I don't feel comfortable adding another config
mechanism via sysprops.
I'm of a split mind here, but I think I would prefer to put this as a property
somewhere in {{solr.xml:/solr/metrics}}, and it still can be parameterized by
sysprops using the existing var substitution mechanism.
> Allow thread metrics to be cached
> ---------------------------------
>
> Key: SOLR-15616
> URL: https://issues.apache.org/jira/browse/SOLR-15616
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Reporter: Ishan Chattopadhyaya
> Assignee: Ishan Chattopadhyaya
> Priority: Major
> Attachments: SOLR-15616.patch
>
>
> Computing JVM metrics for threads can be expensive, and we should provide
> option to users to avoid doing so on every call to the metrics API
> (group=jvm).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
