[ 
https://issues.apache.org/jira/browse/SOLR-15639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420418#comment-17420418
 ] 

Mark Robert Miller commented on SOLR-15639:
-------------------------------------------

Okay, so for the main issue around the IncrementalBackupTests, it had 
originally looked like a leak of a SolrClient, one that you can work around 
with ObjectReleaseTracker#tryClose, but eventually I ended up with fine 
behavior by just changing the rule mock into an object and calling the right 
methods in before and after class. So now as I look it at, I think it's 
actually some incorrect ordering / racing with the ObjectReleaseTracker and the 
Rule tear down. So I'll start with just putting up the mock conversion for this 
test and a before and after comparison.

FYI, the problematic object:
{noformat}
java.lang.AssertionError: ObjectTracker found 1 object(s) that were not 
released!!! [InternalHttpClient]java.lang.AssertionError: ObjectTracker found 1 
object(s) that were not released!!! 
[InternalHttpClient]org.apache.http.impl.client.InternalHttpClient:org.apache.solr.common.util.ObjectReleaseTracker$ObjectTrackerException:
 org.apache.http.impl.client.InternalHttpClient at 
org.apache.solr.common.util.ObjectReleaseTracker.track(ObjectReleaseTracker.java:40)
 at 
org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:348)
 at 
org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:357)
 at 
org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:295)
 at 
org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:282)
 at 
org.apache.solr.client.solrj.impl.HttpSolrClient.<init>(HttpSolrClient.java:207)
 at 
org.apache.solr.client.solrj.impl.HttpSolrClient$Builder.build(HttpSolrClient.java:991)
 at 
org.springframework.boot.autoconfigure.solr.SolrAutoConfiguration.solrClient(SolrAutoConfiguration.java:51)
 {noformat}

> S3 tests are needlessly slow.
> -----------------------------
>
>                 Key: SOLR-15639
>                 URL: https://issues.apache.org/jira/browse/SOLR-15639
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: contrib - S3 Repository, Tests
>            Reporter: Mark Robert Miller
>            Assignee: Mark Robert Miller
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to