magibney commented on pull request #304: URL: https://github.com/apache/solr/pull/304#issuecomment-927903081
Nice! I see the spirit of most of the changes suggested in https://github.com/dweiss/solr/pull/1 is incorporated in the recently force-pushed commits. I'm curious about what you think of the change suggested in [this commit](https://github.com/dweiss/solr/pull/1/commits/3fa6f151109ad62f6d535e38dd6d7600314fddfe): allowing the `lucene-dev-repo` path to be explicitly specified (via system property), as opposed to supporting only a single default path (within the solr work tree) and allowing that default to be disabled? This seems a bit more flexible, and doesn't really lose you anything in terms of usability afaict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
