magibney commented on pull request #304:
URL: https://github.com/apache/solr/pull/304#issuecomment-928240111
>Will such a configurable property even be used?
It occurred to me to add it because I wanted to use it, fwiw :-)
If doing Lucene and Solr development, forcing the repo for the former to
live within the directory of the latter seems needlessly restrictive when
there's a reasonably straightforward alternative. I initially tried this with
symlinking into a sibling lucene directory, but the security policy
(understandably) complained. Supporting explicit `lucene-dev-dir` specification
wouldn't preclude still supporting a "lucene subdirectory"
convention-over-configuration approach.
Understood that this would arguably be more appropraite as a `-P` project
property -- but this PR is already justifiably compromising on that principle
in order to support the roughly-analogous behavior of disabling the default
handling of `lucene.dev.repo`:
```
// Allow turning off this auto-wiring via -Dlucene.dev.repo=false (can't
be a -P property because
// at settings evaluation time we don't have project properties yet).
```
In any case this will work fine for me in its current state, and I really
appreciate the attention you've put toward this issue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
