dsmiley commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-953442337
@joel-bernstein I know you've had some concerns about what sort of things happen without a JIRA so I request your opinion here. The point of this PR is to: * Downgrade many dependency declarations from "api" scope to lesser (typically implementation) to thus have modules state more clearly what they actually need ** in some source files, switched to a Java 11 idiom to avoid a needless dependency on some deps by the module it's a part of * organize solr-core's build.gradle file -- for example keep the Hadoop Auth stuff together * solr-core & solrj's build.gradle file: use transitive dependencies, finally. Thus remove dependency declarations that become needless. We didn't allow ourselves this in the previous build system to avoid unwittingly adding a transitive but our current build system ensures we are aware of them, at least at a whole-project level in `versions.lock`. This was a big part of what I wanted to do. However there are some things that I didn't intend (didn't set out to do) that should nevertheless happen any way (based on the transitive dependency tree), but maybe slightly muddy the refactor/tune-up aspect of this JIRA-less PR: * Janino is upgraded from 3.0.9 to 3.0.11. * net.hydromatic:eigenbase-properties isn't needed from Calcite after all? (in tests we trust?) * kerby-kdc isn't needed for Hadoop Auth testing after all (in tests we trust) WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
