madrob commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-956423330
When I was working on SOLR-15555, the current behavior of closing the SRI helped me find a bug, so I'm reasonably confident that we don't want to change things to strict. If we do, then we should treat it like SolrCore close, where if there are too many calls to it then we log it and ask the person to create an issue - it more than likely means a bug in our code already. `SRI.getInheritableThreadLocalProvider().clean()` is supposed to remove the context done by `set` - looks like this came from SOLR-14384 and maybe we didn't get all of the usages there? I'm still speaking in generalities here, but I'm getting more and more convinced that the problem isn't with SRI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
