madrob commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-960003705
I thought the problem here was that we end up calling close too many times, right? So like on SolrCore, if we call close on the hook multiple times we could log about it instead of silently ignoring the other times. clean closing SRI is fine because it's supposed to be mirrored by creating a new entry on the SRI stack during `set`. So if something is calling `clean` to call `close`, that means it didn't call `set` before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
