[ 
https://issues.apache.org/jira/browse/SOLR-15788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442258#comment-17442258
 ] 

David Eric Pugh commented on SOLR-15788:
----------------------------------------

The method {{legacyExampleCollection1SolrHome}} on {{SolrJettyTestBase}} is 
used 3 times in solr/core and and 26 times in solr/solrj.   

This makes me wonder if I can just change up how those three tests in solr/core 
work, to look up more normal configurations that may already exist in 
/solr/core/src/test-files/solr/ and then move 
{{legacyExampleCollection1SolrHome}} to look up the {testproducts} 
configuration from {{solr/solrj/src/test-files/solrj/solr/}}  ???

It seems like we would not want tests in {{solr/core}} to reference 
configuration files in {{solr/solrj}} ;-)

> Remove configset/sample_techproducts_config from being used in unit tests.
> --------------------------------------------------------------------------
>
>                 Key: SOLR-15788
>                 URL: https://issues.apache.org/jira/browse/SOLR-15788
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>    Affects Versions: main (9.0)
>            Reporter: David Eric Pugh
>            Assignee: David Eric Pugh
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is to remove the use of the method {{legacyExampleCollection1SolrHome}} 
> which points to the 
> {{solr/server/solr/configsets/sample_techproducts_configs}} directory, which 
> means that as we make changes to our techproducts demos in the ref guide, we 
> break unit tests, or, if we change it to support a unit test, we break 
> something else.
> This is to experiment with moving the techproducts configs into 
> {{solr/solrj/test-files}} and {{solr/core/test-files/}} directories, and then 
> trying to slim them down.   I'm going to call the config "testproducts" ;-)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to