[ 
https://issues.apache.org/jira/browse/SOLR-15788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442435#comment-17442435
 ] 

David Eric Pugh commented on SOLR-15788:
----------------------------------------

[~mdrob] I just found in {{EmbeddedSolrServerTestBase}}, which is in the 
{{test-framework}} project a copy of the {{legacyExampleCollection1SolrHome}} 
method!   

I am trying out replacing it with instead a call to 
{{SolrJettyTestBase.legacyExampleCollection1SolrHome()}}...

It makes me wonder, would there be an argument for having the techproducts 
configuraiton for unit testing actually be PART of the {{test-framework}} 
project???

> Remove configset/sample_techproducts_config from being used in unit tests.
> --------------------------------------------------------------------------
>
>                 Key: SOLR-15788
>                 URL: https://issues.apache.org/jira/browse/SOLR-15788
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>    Affects Versions: main (9.0)
>            Reporter: David Eric Pugh
>            Assignee: David Eric Pugh
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is to remove the use of the method {{legacyExampleCollection1SolrHome}} 
> which points to the 
> {{solr/server/solr/configsets/sample_techproducts_configs}} directory, which 
> means that as we make changes to our techproducts demos in the ref guide, we 
> break unit tests, or, if we change it to support a unit test, we break 
> something else.
> This is to experiment with moving the techproducts configs into 
> {{solr/solrj/test-files}} and {{solr/core/test-files/}} directories, and then 
> trying to slim them down.   I'm going to call the config "testproducts" ;-)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to