janhoy commented on a change in pull request #424: URL: https://github.com/apache/solr/pull/424#discussion_r752384726
########## File path: solr/bin/solr ########## @@ -2073,8 +2073,8 @@ else fi # IP-based access control -IP_ACL_OPTS=("-Dsolr.jetty.inetaccess.includes=${SOLR_IP_WHITELIST}" \ - "-Dsolr.jetty.inetaccess.excludes=${SOLR_IP_BLACKLIST}") +IP_ACL_OPTS=("-Dsolr.jetty.inetaccess.includes=${SOLR_IP_ALLOWLIST}" \ + "-Dsolr.jetty.inetaccess.excludes=${SOLR_IP_DENYLIST}") Review comment: I could have tried to support both in parallel for some time and warned when detecting the old, but it's a hassle across bash and Windows - any strong feelings about this? We spell it out in upgrade notes... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org