janhoy commented on a change in pull request #424:
URL: https://github.com/apache/solr/pull/424#discussion_r755176129
##########
File path: solr/bin/solr
##########
@@ -2073,8 +2073,8 @@ else
fi
# IP-based access control
-IP_ACL_OPTS=("-Dsolr.jetty.inetaccess.includes=${SOLR_IP_WHITELIST}" \
- "-Dsolr.jetty.inetaccess.excludes=${SOLR_IP_BLACKLIST}")
+IP_ACL_OPTS=("-Dsolr.jetty.inetaccess.includes=${SOLR_IP_ALLOWLIST}" \
+ "-Dsolr.jetty.inetaccess.excludes=${SOLR_IP_DENYLIST}")
Review comment:
On second thought, since this is about security (IP filtering), I plan
to make the bin/solr scripts print an error and exit if the old env.var is set.
That is fail-fast, and users can re-configure to use the new variable names and
start again. Already tested a fix for linux. Need to test same for bin/solr.cmd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
