[ https://issues.apache.org/jira/browse/SOLR-15845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464482#comment-17464482 ]
Jan Høydahl commented on SOLR-15845: ------------------------------------ So I started out duplicating Lucene's Version class in PR 469, recording previous Solr versions as constants. But then I could not find a good reason to have constants for every previous solr version in there, so I put up PR 472 where the SolrVersion class is much simpler and delegates all version comparison to the SemVer lib. I kept the logic of updating SolrVersion.java from addVersion.py script, but there is perhpas a simper way involving gradle? Appreciate feedback on what else we really need to use the SolrVersion class for. Perhaps we need a historic record somewhere of what Lucene version was included in each Solr version? Say we release Solr 9.0.0 on Lucene 9.1 and then release Solr 10.0 on Lucene 9.5, and Solr 11.0 on Lucene 10.0. Perhaps some logic somewhere would need to know that a Solr 11 is in fact index-compatible with Solr 9? Perhaps SolrOperator would need that kind of info, but are there similar needs inside of Solr code? > Solr needs its own Version class > -------------------------------- > > Key: SOLR-15845 > URL: https://issues.apache.org/jira/browse/SOLR-15845 > Project: Solr > Issue Type: Improvement > Affects Versions: 9.0 > Reporter: Jan Høydahl > Assignee: Jan Høydahl > Priority: Blocker > Fix For: main (9.0) > > Time Spent: 40m > Remaining Estimate: 0h > > From 9.0 on, Solr may release with a different version number than the Lucene > it depends on, since Lucene is just another jar dependency now. > Several places in our code base we either print a version based on Lucene > Version, or make other decisions based on it. It's still the correct Version > to use for index compatibility and analysis plugins, but other places we need > a {{SolrVersion}} to replace it. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org