[
https://issues.apache.org/jira/browse/SOLR-15845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465295#comment-17465295
]
David Smiley commented on SOLR-15845:
-------------------------------------
Thanks for making progress on this Jan! I reviewed your PR and also reviewed
the spots you didn't change by looking for remaining usages of Lucene's
Version, aided by an IDE.
Our solrconfig.xml/SolrConfig can specify luceneMatchVersion. The purpose of
this setting is to gate some features on the version so that you could upgrade
Solr yet keep compatibility with whatever your config is. Looking in 8x, I see
we've done that for something in edismax (thus query time) but it's also been
done in index time settings, perhaps influencing how data is tokenized. I
don't see uses of it in 9x since the existing usages were removed due to
deprecations of old settings but more could be added at any time in the future.
With the Lucene/Solr split, I think the name of this setting is wrong; really
it's to the whole stack and thus primarily Solr. Perhaps a setting name of
"solrVersionCompatibility" would be nice as it helps indicate its purpose.
Shouldn't SolrVersion refer to Lucene's Version? Admittedly I'm not sure yet
what the use-case is for resolving the corresponding version for non-latest.
Another option for solrconfig.xml luceneMatchVersion is to do away with it
entirely. Maybe it's used too little to warrant the upkeep, both here/now and
also by our users? This isn't my preference but I can sympathize.
> Solr needs its own Version class
> --------------------------------
>
> Key: SOLR-15845
> URL: https://issues.apache.org/jira/browse/SOLR-15845
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 9.0
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Blocker
> Fix For: main (9.0)
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> From 9.0 on, Solr may release with a different version number than the Lucene
> it depends on, since Lucene is just another jar dependency now.
> Several places in our code base we either print a version based on Lucene
> Version, or make other decisions based on it. It's still the correct Version
> to use for index compatibility and analysis plugins, but other places we need
> a {{SolrVersion}} to replace it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
