ijioio commented on pull request #479: URL: https://github.com/apache/solr/pull/479#issuecomment-1009625781
Hi, @HoustonPutman Thanks for the message! > @ijioio I think this would be great to get into 9.0, because of the backwards incompatibility. Just to clarify, you're talking about backup format (`Response` update to use `NamedList` instead of `String`) or about aggregated part of the response (switching from `array` to `dictionary`)? Or both?. Sorry if I don't understand you correctly. I think I can switch `Response` of type `String` to `response` with `NamedList` of the actual response and investigate more deeply. But as @cpoerschke mentioned above it should be first decided is it OK to make those kinds of general changes. All the async managing for the collections are handled by `org.apache.solr.cloud.api.collections.CollectionHandlingUtils.ShardRequestTracker`. First the `sendShardRequest(String, ModifiableSolrParams, ShardHandler, String, ZkStateReader)` is called which will place `asyncId` (if provided) to tracking map `shardAsyncIdByNode`. Then, method `processResponses(NamedList<Object>, ShardHandler, boolean, String, Set<String>)` is executed. In case the initial request was in async mode it will additionaly call `waitForAsyncCallsToComplete` method at the end to gather all the results from all the shards. I suppose originally an idea was to implement the universal async system. So in theory, it is possible to call any distributed operation in async mode. That makes me think that no internal parsing of the shards results is applied except some special cases (like aggregation for backup). Checking of all the possible operations that call `processResponses` to understand how they handle results will take time (it doesn't mean it is impossible though :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
