ijioio edited a comment on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1010953596


   > It seems like you and @cpoerschke are in favor of removing Response 
altogether, just leaving response. I think it would be fine to change Response 
-> message and leave the information, but if y'all don't think it's useful I 
won't put up a fight.
   
   I'm OK with both ways. I probably more tended for the remove option because 
`toLog` list seems to be intended for logging purposes, not for building 
responses. I've checked the usages of it and it is always used for logging only 
(except the case of async calls of admin operations mentioned in this issue). 
There is also a case of using `toLog` to store `hits` value but it is used just 
as a value holder, not for the response. It is easy to see if you check the 
calls of `org.apache.solr.response.SolrQueryResponse.getToLog()` and 
`org.apache.solr.response.SolrQueryResponse.getToLogAsString(String)`. Another 
reason is that all this data appear as a response only in an internal 
subrequest data of async call, not in an outer initial request data, so 
internal `Request` data seems valuable for me only for debugging purposes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to