magibney commented on a change in pull request #513:
URL: https://github.com/apache/solr/pull/513#discussion_r788335896
##########
File path:
solr/core/src/java/org/apache/solr/response/transform/GeoTransformerFactory.java
##########
@@ -144,88 +148,111 @@ public void transform(SolrDocument doc, int docid)
throws IOException {
}
+ // if source has been renamed, update reference
Review comment:
Yes, basically the fact that this class had been doing renaming _outside
the context of "simple" renaming that corrected for interactions with other
field renames_ was a latent problem (perhaps I could/should add a test to
stress this issue -- though I might leave that for another issue?). I'm going
to think about this, and the "`FieldRenamer` interface vs. "subclass of
`TransformerFactory`" question -- perhaps there's a way to factor some of this
logic out so it can live in once place and not be the responsibility of each
`FieldRenamer` implementation. I'll report back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
