magibney commented on pull request #513: URL: https://github.com/apache/solr/pull/513#issuecomment-1015742408
>if you wanted to make it easier to write new transformers like this, is there any other changes you would make? I don't think so. Indeed, if someone went to implement their own custom `DocTransformer` that sought to write directly (unescaped) to output, they would currently replace the field value on each doc with an instance of the `WriteableValue` interface ... and their custom plugin would consequently be incompatible with cloud. The new way would be to override the new (default no-op) `DocTransformer.getRawFields(Collection<String> addToExisting)` method to add the output field (to be written raw) to the specified collection. Should then be compatible with cloud, but otherwise work the same as currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
