ijioio commented on pull request #479: URL: https://github.com/apache/solr/pull/479#issuecomment-1019224284
> The change from 'Response' to 'msg' turned out to be very easy and didn't affect much else, so I went ahead and did it. This also allowed me to remove the RESPONSE variable, since it is no longer in use (meaning that we won't see it in any other responses). > I also added in the incremental backup information indexFileCount, uploadedIndexFileCount, uploadedIndexFileMB and shardBackupIds in the aggregated response. (if they are in the initial response) Thanks for the updates! Looks great! > @ijioio I think this should be good to go. Would you mind testing it out locally? Then I can get to work on SOLR-15884 And have this in before 9.0! Sure! Here is the response I've got locally, seems works OK: ```json { "responseHeader": { "status": 0, "QTime": 1 }, "success": { "localhost:8983_solr": { "responseHeader": { "status": 0, "QTime": 0 } }, "localhost:8983_solr": { "responseHeader": { "status": 0, "QTime": 0 } }, "localhost:8983_solr": { "responseHeader": { "status": 0, "QTime": 0 }, "STATUS": "completed", "msg": "TaskId: 10006758022670100 webapp=null path=/admin/cores params={core=techproducts_shard2_replica_n2&async=10006758022670100&qt=/admin/cores&name=shard2&shardBackupId=md_shard2_0&action=BACKUPCORE&location=file:///path/to/my/shared/drive/mybackup/techproducts&incremental=true&wt=javabin&version=2} status=0 QTime=0", "response": { "startTime": "2022-01-22T12:01:32.192663Z", "indexFileCount": 1, "uploadedIndexFileCount": 1, "indexSizeMB": 0.001, "uploadedIndexFileMB": 0.001, "shard": "shard2", "endTime": "2022-01-22T12:01:34.928067Z", "shardBackupId": "md_shard2_0" } }, "localhost:8983_solr": { "responseHeader": { "status": 0, "QTime": 0 }, "STATUS": "completed", "msg": "TaskId: 10006758023398500 webapp=null path=/admin/cores params={core=techproducts_shard1_replica_n4&async=10006758023398500&qt=/admin/cores&name=shard1&shardBackupId=md_shard1_0&action=BACKUPCORE&location=file:///path/to/my/shared/drive/mybackup/techproducts&incremental=true&wt=javabin&version=2} status=0 QTime=0", "response": { "startTime": "2022-01-22T12:01:32.192663Z", "indexFileCount": 21, "uploadedIndexFileCount": 21, "indexSizeMB": 0.006, "uploadedIndexFileMB": 0.006, "shard": "shard1", "endTime": "2022-01-22T12:01:35.505593300Z", "shardBackupId": "md_shard1_0" } } }, "10006758022670100": { "responseHeader": { "status": 0, "QTime": 0 }, "STATUS": "completed", "msg": "TaskId: 10006758022670100 webapp=null path=/admin/cores params={core=techproducts_shard2_replica_n2&async=10006758022670100&qt=/admin/cores&name=shard2&shardBackupId=md_shard2_0&action=BACKUPCORE&location=file:///path/to/my/shared/drive/mybackup/techproducts&incremental=true&wt=javabin&version=2} status=0 QTime=0", "response": { "startTime": "2022-01-22T12:01:32.192663Z", "indexFileCount": 1, "uploadedIndexFileCount": 1, "indexSizeMB": 0.001, "uploadedIndexFileMB": 0.001, "shard": "shard2", "endTime": "2022-01-22T12:01:34.928067Z", "shardBackupId": "md_shard2_0" } }, "10006758023398500": { "responseHeader": { "status": 0, "QTime": 0 }, "STATUS": "completed", "msg": "TaskId: 10006758023398500 webapp=null path=/admin/cores params={core=techproducts_shard1_replica_n4&async=10006758023398500&qt=/admin/cores&name=shard1&shardBackupId=md_shard1_0&action=BACKUPCORE&location=file:///path/to/my/shared/drive/mybackup/techproducts&incremental=true&wt=javabin&version=2} status=0 QTime=0", "response": { "startTime": "2022-01-22T12:01:32.192663Z", "indexFileCount": 21, "uploadedIndexFileCount": 21, "indexSizeMB": 0.006, "uploadedIndexFileMB": 0.006, "shard": "shard1", "endTime": "2022-01-22T12:01:35.505593300Z", "shardBackupId": "md_shard1_0" } }, "response": { "collection": "techproducts", "numShards": 2, "backupId": 0, "indexVersion": "9.0.0", "startTime": "2022-01-22T12:01:29.247112200Z", "indexFileCount": 22, "uploadedIndexFileCount": 22, "indexSizeMB": 0.007, "uploadedIndexFileMB": 0.007, "shardBackupIds": [ "md_shard2_0", "md_shard1_0" ] }, "status": { "state": "completed", "msg": "found [1000] in completed tasks" } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org