[ https://issues.apache.org/jira/browse/SOLR-14686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481545#comment-17481545 ]
ASF subversion and git services commented on SOLR-14686: -------------------------------------------------------- Commit d781148ad804358f2b0ae08b609e5ff9329f70bf in solr's branch refs/heads/branch_9_0 from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=d781148 ] SOLR-14686: Logs: Remove log "[coreName]" in SolrCore which is redundant with MDC (#517) Also, ensured any problems in SolrCore.close has MDC info in logs. > Remove log "[coreName]" (logid) which is redundant with MDC > ----------------------------------------------------------- > > Key: SOLR-14686 > URL: https://issues.apache.org/jira/browse/SOLR-14686 > Project: Solr > Issue Type: Improvement > Components: logging > Reporter: David Smiley > Assignee: David Smiley > Priority: Blocker > Fix For: 9.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > SolrCore.logid is used mostly by some log statements within SolrCore to log > the core name at the start of some (not all) log messages. It pre-dated MDC > and I believe it's basically obsolete now, and contributes to needless > logging verbosity. The info levels where this appears if for opening a new > SolrCore, closing a SolrCore, registering a new searcher, and it's in the > "requestLog" and thus will show up once for any HTTP request into a core > (e.g. select, update, etc.). So removing this will disturb anyone parsing > Solr's logs. Maybe this should wait till 9.0? > There is _some_ value still because for cross-core join query, any pertinent > log statements on the "fromIndex" would ideally be reported against that > core and not the toIndex. That seems too minor to keep this old stuff around > for though. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org