markrmiller commented on a change in pull request #585: URL: https://github.com/apache/solr/pull/585#discussion_r810457205
########## File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java ########## @@ -68,8 +69,12 @@ public static void processParams(SolrRequestHandler handler, SolrQueryRequest re String[] jsonFromParams = map.remove(JSON); // params from the query string should come after (and hence override) JSON content streams for (ContentStream cs : req.getContentStreams()) { + // if BinaryResponseParser.BINARY_CONTENT_TYPE, let the following fail below - we may have adjusted the content without updating the content type + // problem in this case happens in a few tests, one seems to happen with kerberos and remote node query (HttpSolrCall's request proxy) + String contentType = cs.getContentType(); - if (contentType==null || !contentType.contains("/json")) { + if (contentType==null || (!contentType.contains("/json") && !contentType.contains( + BinaryResponseParser.BINARY_CONTENT_TYPE))) { Review comment: 3 or 4 tests fail due to the search handler and it's content header check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org