[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495590#comment-17495590
]
Erick Erickson commented on SOLR-14920:
---------------------------------------
It's vaguely possible that I can help here. Before jumping in though, how is it
all being coordinated? In particular, the issue of all those commits being
difficult to do diffs across.... Being off in the weeds like I am, I have no
real say in the matter of course....
When we did Lucene, Dawid maintained a separate branch where all the
format-only commits went. When it was all done, there was one big merge back to
trunk. This took considerable dedication on his part because all the code
changes in the main line code had to be merged into the branch while the
reformatting was in process. The advantage was that there was exactly one
commit that could be ignored in order to be able to do effective diffs across
the code base without having all the noise to deal with from format-only.
If consensus has already been reached, just let me know what the process is and
I'll shut up ;). Again, I don't have any input into what the process is, just
want to follow what the process is...
And I haven't been looking at JIRAs in almost a year, so I've missed any
discussions here please point me in the right direction...
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 4h
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
