[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495627#comment-17495627 ]
Houston Putman commented on SOLR-14920: --------------------------------------- *solr-ref-guide* no longer has any non-example java code. In my opinion, the example code doesn't really need to have spotless enforced and there, so IMO no need to do anything there other than remove it from the exclusion list. I tested it locally and it worked as expected, no changed files when the exclusion is removed and {{gradlew tidy}} is run. > Format code automatically and enforce it in Solr > ------------------------------------------------ > > Key: SOLR-14920 > URL: https://issues.apache.org/jira/browse/SOLR-14920 > Project: Solr > Issue Type: Improvement > Reporter: Erick Erickson > Priority: Major > Labels: codestyle, formatting > Time Spent: 4h 20m > Remaining Estimate: 0h > > See the discussion at: LUCENE-9564. > This is a placeholder for the present, I'm reluctant to do this to the Solr > code base until after: > * we have some Solr-specific consensus > * we have some clue what this means for the reference impl. > Reconciling the reference impl will be difficult enough without a zillion > format changes to add to the confusion. > So my proposal is > 1> do this. > 2> Postpone this until after the reference impl is merged. > 3> do this in one single commit for reasons like being able to conveniently > have this separated out from git blame. > Assigning to myself so it doesn't get lost, but anyone who wants to take it > over please feel free. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org