[ 
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497837#comment-17497837
 ] 

Erick Erickson commented on SOLR-14920:
---------------------------------------

Well, it went faster the second time around. My fork 
([https://github.com/ErickErickson/solr)] has all of solr run through Spotless 
with no exclusions for perusal..... It is a fork of the main line code as of 
about 6 PM Eastern....

Note, all I can say at this point is that all the tests pass and "gradlew 
build" succeeds. I'm a bit uncertain about all the document builds, the website 
(Antora?) and I have certainly not diff'ed each file individually.....

I'll fade into the background now and watch the discussion for a day or 
three... ;)

> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
>                 Key: SOLR-14920
>                 URL: https://issues.apache.org/jira/browse/SOLR-14920
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Erick Erickson
>            Priority: Major
>              Labels: codestyle, formatting
>          Time Spent: 8.5h
>  Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr 
> code base until after:
>  * we have some Solr-specific consensus
>  * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion 
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently 
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it 
> over please feel free.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to