[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497476#comment-17497476
]
Kevin Risden commented on SOLR-14920:
-------------------------------------
Sorry [~erickerickson] saw your message and then it got buried under my
.git-blame-ignore-revs updates.
1. as of right now I guess I'm coordinating? I created jiras for the work I was
doing and said these are things I'm not touching
2. yup
3. yup (although I haven't seen any failures from the reformatting myself)
4. push it all to the appropriate branches <- this is where I've been trying to
get at least one other review before merging. the ltr module [~cpoerschke]
cleaned up a few weird formatting things (ie: java doc ending with **/ was
being formatted as * SPACE */). Most of the formatting works well. If you break
it into small enough chunks its reviewable - other times its not easily
reviewable.
5. yup
As far as what to tackle next - I don't have an opinion other than I've argued
with myself whether to do all say solrj at once or by package. Either way is
going to make backporting rough. The modules at least were reasonable
standalone - core/solrj is going to probably break most of the outstanding PRs
(only ~100 so not terrible). My thought is we should finish the job now while
the iron is hot - so lets do it and pull that bandaid off.
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
