[ 
https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500960#comment-17500960
 ] 

Houston Putman commented on SOLR-14401:
---------------------------------------

I like the new label approach the best, easiest to make dashboards for. And as 
for the label, I think either work. Maybe the internal=shard/false for future 
extensibility. 

> "distrib" request handler metrics should only be tracked on pertinent handlers
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-14401
>                 URL: https://issues.apache.org/jira/browse/SOLR-14401
>             Project: Solr
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Blocker
>             Fix For: 9.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> SOLR-13979 in 8.4 added separate request handler metrics for distributed 
> requests.  However this was done for _all_ request handlers, even though it's 
> mainly SearchHandler (and maybe one or two others?) where a distributed 
> request is even possible.  I refer to this as "metrics pollution" and it's a 
> bad thing.  It's more weight per handler (latency load & memory), more weight 
> for Solr metrics responses, and it's also _suggestive_ that all registered 
> handlers can have distributed requests when this is quite false, thus 
> confusing people.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to