[ 
https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506690#comment-17506690
 ] 

ASF subversion and git services commented on SOLR-14401:
--------------------------------------------------------

Commit a8ae85336611475f93b51b7a5e2c0ad87209700d in solr's branch 
refs/heads/jira/SOLR15715_1 from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=a8ae853 ]

SOLR-14401: Track distrib/shard metrics differently (#657)

* only do for SearchHandler, not all request handlers (less metrics overall)
* track all the same details at the shard level as request (more detailed 
metrics)
* use [shard] suffix; do away with .distrib. and .local.
* don't limit this to SolrCloud

Prometheus Exporter & Grafana config:
* remove select ".distrib."; this is the default semantic
* remove ".local." additions because these are already expressed via separate 
request handlers with a suffix
* time_seconds_total computed differently; looks suspicious
* extract an "internal" Prometheus label from the handler; has values "shard" 
or "false".  Updated Grafana to use this to match former logic.

Misc:
* prometheus gradle: fix "run" task
* fix README link

Co-authored-by: Houston Putman <hous...@apache.org>

> "distrib" request handler metrics should only be tracked on pertinent handlers
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-14401
>                 URL: https://issues.apache.org/jira/browse/SOLR-14401
>             Project: Solr
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Blocker
>             Fix For: 9.0
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> SOLR-13979 in 8.4 added separate request handler metrics for distributed 
> requests.  However this was done for _all_ request handlers, even though it's 
> mainly SearchHandler (and maybe one or two others?) where a distributed 
> request is even possible.  I refer to this as "metrics pollution" and it's a 
> bad thing.  It's more weight per handler (latency load & memory), more weight 
> for Solr metrics responses, and it's also _suggestive_ that all registered 
> handlers can have distributed requests when this is quite false, thus 
> confusing people.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to