[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

[GitBox]

laminelam commented on code in PR #857:
URL: https://github.com/apache/solr/pull/857#discussion_r870827470


##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -323,22 +329,29 @@ public ZkController(
     ZkClientConnectionStrategy strat =
         ZkClientConnectionStrategy.forName(connectionStrategy, new 
DefaultConnectionStrategy());
 
+    String zkCredentialsInjectorClass = 
cloudConfig.getZkCredentialsInjectorClass();
+    ZkCredentialsInjector zkCredentialsInjector =
+        !StringUtils.isEmpty(zkCredentialsInjectorClass)
+            ? cc.getResourceLoader()
+                .newInstance(zkCredentialsInjectorClass, 
ZkCredentialsInjector.class)
+            : new DefaultZkCredentialsInjector();
+
     String zkACLProviderClass = cloudConfig.getZkACLProviderClass();
-    ZkACLProvider zkACLProvider = null;
-    if (zkACLProviderClass != null && zkACLProviderClass.trim().length() > 0) {
-      zkACLProvider = cc.getResourceLoader().newInstance(zkACLProviderClass, 
ZkACLProvider.class);
-    } else {
-      zkACLProvider = new DefaultZkACLProvider();
-    }
+    ZkACLProvider zkACLProvider =
+        !StringUtils.isEmpty(zkACLProviderClass)
+            ? cc.getResourceLoader().newInstance(zkACLProviderClass, 
ZkACLProvider.class)
+            : new DefaultZkACLProvider();

Review Comment:
   
   
   I think it’s more readable and less verbose. 
   Compare 
   this
   
   ```
   ZkACLProvider zkACLProvider = null;
       if (zkACLProviderClass != null && zkACLProviderClass.trim().length() > 
0) {
         zkACLProvider = cc.getResourceLoader().newInstance(zkACLProviderClass, 
ZkACLProvider.class);
       } else {
         zkACLProvider = new DefaultZkACLProvider();
       }
   ```
   
   
   to this
   
   
   ```
   ZkACLProvider zkACLProvider = !StringUtils.isEmpty(zkACLProviderClass) ?
          cc.getResourceLoader().newInstance(zkACLProviderClass, 
ZkACLProvider.class)
          : new DefaultZkACLProvider();
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org