laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r872750831
########## solr/solrj/src/java/org/apache/solr/common/cloud/acl/ZkACLProvider.java: ########## @@ -14,12 +14,14 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.solr.common.cloud; +package org.apache.solr.common.cloud.acl; import java.util.List; import org.apache.zookeeper.data.ACL; public interface ZkACLProvider { List<ACL> getACLsToAdd(String zNodePath); + + void setZkCredentialsInjector(ZkCredentialsInjector zkCredentialsInjector); Review Comment: Great point. Added a default non-op method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org