laminelam commented on code in PR #857:
URL: https://github.com/apache/solr/pull/857#discussion_r887940274
##########
solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java:
##########
@@ -236,8 +240,11 @@ protected ZkCredentialsProvider
createZkCredentialsToAddAutomatically() {
if (!StringUtils.isEmpty(zkCredentialsProviderClassName)) {
try {
log.info("Using ZkCredentialsProvider: {}",
zkCredentialsProviderClassName);
- return (ZkCredentialsProvider)
-
Class.forName(zkCredentialsProviderClassName).getConstructor().newInstance();
+ ZkCredentialsProvider zkCredentialsProvider =
+ (ZkCredentialsProvider)
+
Class.forName(zkCredentialsProviderClassName).getConstructor().newInstance();
Review Comment:
This is an existing code, not part of this PR, are you suggesting to change
that too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
