epugh commented on code in PR #889:
URL: https://github.com/apache/solr/pull/889#discussion_r888292055


##########
solr/solr-ref-guide/modules/query-guide/pages/learning-to-rank.adoc:
##########
@@ -111,11 +111,15 @@ In the form of JSON files your trained model or models 
(e.g., different models f
 |(custom) |(custom class extending 
{solr-javadocs}/modules/ltr/org/apache/solr/ltr/model/LTRScoringModel.html[LTRScoringModel])
 |(not applicable)
 |===
 
+== Module
+
+This is provided via the `ltr` xref:configuration-guide:solr-modules.adoc[Solr 
Module] that needs to be enabled before use.
+
 == Quick Start with LTR
 
-The `"techproducts"` example included with Solr is pre-configured with the 
plugins required for learning-to-rank, but they are disabled by default.
+The `"techproducts"` example included with Solr is pre-configured to load the 
plugins required for learning-to-rank from the `ltr` 
xref:configuration-guide:solr-modules.adoc[Solr Module], but they are disabled 
by default.
 
-To enable the plugins, please specify the `solr.ltr.enabled` JVM System 
Property when running the example:
+To enable the plugins, please specify the `solr.ltr.enabled` JVM System 
Property when running the `techproducts` example:

Review Comment:
   Oddly enough, you don't!!!   Cause we do that hacky `<lib>` stuff in the 
techproducts, wrapping it all with a system param to enable that code!    Part 
of me would love to just deprecate the use of the `<lib>` stuff for the Solr 
Modules, and only keep it for folks doing non Module things...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to