eliaporciani opened a new pull request, #910: URL: https://github.com/apache/solr/pull/910
https://issues.apache.org/jira/browse/SOLR-16245 # Description Make DenseVectorField codec agnostic. It is no longer possible to specify the codec (the default is the last codec available) but only the algorithm. Currently, the only available algorithm is HNSW. # Solution The parameter codecFormat is changed with the parameter knnAlgorithm. It is still necessary to override the method getKnnVectorsFormatForField of Lucene91Codec for using advanced hyper-parameters for hnsw: https://issues.apache.org/jira/browse/LUCENE-10612 The usage Lucene90HnswCodecFormat has been removed. The codec selected is always the last one (Lucene91HnswCodecFormat in this case). This is back-compatible with Lucene90HnswCodecFormat, then, even in the case of Solr upgrade, everything continues to work correctly: * The old segments are read with Lucene90HnswCodecFormat * The new segments are written with Lucene91HnswCodecFormat * In case of segment merge, the resulting segments are written with Lucene90HnswCodecFormat. # Tests Modified tests in DenseVectorFieldTest for checking that the configuration is taken correctly. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
